1040953 - Add media [images, videos] to "Composing" page

Status: RESOLVED FIXED

(Webmaker Graveyard :: Teaching Kits / Curriculum, defect)

Description

[Kat Braybrooke [:codekat]]

Context: 
* Images bug discussion https://bugzilla.mozilla.org/show_bug.cgi?id=1018274
* Early work here https://etherpad.mozilla.org/webmakertextbookassets 

To do: Add media to "competency" page.

Comment 1

[Kat Braybrooke [:codekat]]

Attachment: Media to be added (for review)

Comment 2

[Kat Braybrooke [:codekat]]

Also adding Claw and Cassie in case they have ideas about images/videos for this competency.

Comment 3

[Matt Thompson (@OpenMatt :OpenMatt)]

* This image is great: https://www.flickr.com/photos/thisisbossi/6876878214

* We *definitely* need workflow for including Popcorn videos on these pages. Essential. Thanks for pushing on that Kat.

Comment 4

[Matt Thompson (@OpenMatt :OpenMatt)]

* For additional images, could we add some screen grabs from "What Screens Want?" 

like
https://dl.dropboxusercontent.com/spa/6c38yp3crbxni5b/hquuuhlr.png

or this gif
http://frankchimero.com/talks/what-screens-want/transcript/burke17.gif

or there's other images and GIFs on that page as well

Comment 5

[Kat Braybrooke [:codekat]]

Oooh, I *LOVE* that gif, Matt. 

And Aki, really sorry to bug you when you're busy, but when you have a moment, did you get a chance to add a shortcode for Popcorn videos within the JSON? I see examples for all other media types, but not Popcorn. Happy to embed direct links, but wanted to check first. 

Thank you!

Comment 6

[Kat Braybrooke [:codekat]]

Update: 

* Discussion about Popcorn embeds has been moved to the [reopened] media embed syntax bug at https://bugzilla.mozilla.org/show_bug.cgi?id=1032389(and this action will be delayed due to Aki's priority work on landing screens)

* Meanwhile, we can try adding these two images to the page if want, Matt? See new attachment for updated code.

Comment 7

[Kat Braybrooke [:codekat]]

Attachment: Media to be added (#2, for review)

2 images to be embedded -- one a smaller (but amazing) gif, the other a high-res Flickr image. 

Have added notes for attribution, and both images are uploaded to S3.

Comment 8

[Kat Braybrooke [:codekat]]

Attachment: Github pull request - content.json

Added image and gif under "composing" "discover" section as first sample bits of media for that page.

Comment 9

[Aki Rose Braun [:akirose]]

Comment on attachment 8461227 [details] [review]
Github pull request - content.json

Just needs a little bit of work!

Comment 10

[Kat Braybrooke [:codekat]]

Attachment: Github pull request #2 - content.json

Tying to make suggested edits - but wasn't sure about the last one. Is this right?

Comment 11

[Kat Braybrooke [:codekat]]

Attachment: Github pull request #3 - content.json

Fixed spacing on line 656 (i think!)

Comment 12

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/ef8207de5ade4a379df87b595fae7159e9a6e01c
Merge pull request #904 from keyboardkat/patch-17

Fixes Bug 1040953 - Add media [images, videos] to "Composing" page

Comment 13

[Kat Braybrooke [:codekat]]

Just wanted to check in on this. Haven't seen it go live yet. On production?

Comment 14

[Aki Rose Braun [:akirose]]

sorry Kat, looks like we haven't been awesome about pushing to production. pushing to staging right now, we'll do a little testing, then push to prod in a bit.

Comment 15

[Kat Braybrooke [:codekat]]

Thanks for letting me know, Aki! I mostly just wanted to see our first Textbook image set looks on the site - wish I had a better way to preview this :)

Comment 16

[Aki Rose Braun [:akirose]]

okie dokie, we're good!

Comment 17

[Kat Braybrooke [:codekat]]

Great, thanks Aki! One last edit before I share this page with others -- embedding a Popcorn video. Will submit PR now!

Comment 18

[Kat Braybrooke [:codekat]]

Resolving again for now; Popcorn embeds not possible in "Make" yet, so we've gone as far as we can for now. Have filed for this change in https://bugzilla.mozilla.org/show_bug.cgi?id=1034371 .